[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 326fff4: Improve w32notify notifications
From: |
Michael Albinus |
Subject: |
Re: master 326fff4: Improve w32notify notifications |
Date: |
Sat, 19 Mar 2016 16:11:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Hi Fabrice,
> diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el
> index d3610f0..3908894 100644
> --- a/test/lisp/filenotify-tests.el
> +++ b/test/lisp/filenotify-tests.el
> @@ -754,7 +757,9 @@ longer than timeout seconds for the events to be
> delivered."
> (should (file-notify-valid-p file-notify--test-desc))
> ;; After removing the watch, the descriptor must not be valid
> ;; anymore.
> + (read-event nil nil file-notify--test-read-event-timeout)
> (file-notify-rm-watch file-notify--test-desc)
> + (read-event nil nil file-notify--test-read-event-timeout)
> (file-notify--wait-for-events
> (file-notify--test-timeout)
> (not (file-notify-valid-p file-notify--test-desc)))
> @@ -776,7 +781,9 @@ longer than timeout seconds for the events to be
> delivered."
> (should (file-notify-valid-p file-notify--test-desc))
> ;; After deleting the directory, the descriptor must not be
> ;; valid anymore.
> + (read-event nil nil file-notify--test-read-event-timeout)
> (delete-directory file-notify--test-tmpfile t)
> + (read-event nil nil file-notify--test-read-event-timeout)
> (file-notify--wait-for-events
> (file-notify--test-timeout)
> (not (file-notify-valid-p file-notify--test-desc)))
I'm curious why you need the additional `read-event' calls. The
following `file-notify--wait-for-events' loops until the condition is
satisfied, calling `read-event' every iteration.
Best regards, Michael.
- Re: master 326fff4: Improve w32notify notifications,
Michael Albinus <=
Re: master 326fff4: Improve w32notify notifications, Andy Moreton, 2016/03/29