Re: [PATCH v2 3/4] Allow network processes to be made with a pre-allocated fd.

[Matthew Leach]

Hi Eli,

Thanks for having another look.

Eli Zaretskii <address@hidden> writes:

>> From: Matthew Leach <address@hidden>
>> Date: Sun, 27 Mar 2016 21:39:42 +0100
>> Cc: Matthew Leach <address@hidden>
>> 
>> * src/process.c (connect_network_socket): Allow a pre-allocated
>> socket descriptor to be used if passed to Emacs, avoiding the call
>> to socket() and bind().
>> (Fmake_network_process): Allow users to pass in :usepassedsocket
>> on the parameter plist to use a socket descriptor that has been
>> passed to Emacs.
>> (wait_reading_process_output): Call socket() & bind() every time.
>> (syms_of_process): New symbol ":usepassedsocket".
>
> Thanks.  I have only one comment: the :usepassedsocket name sounds
> weird (why "passed"?).  

I was going for "use the socket that was passed over to Emacs", but yes
I think the name could be better.

> How about :use-systemd-socket instead?

One of the comments on the last version of patches was to try and keep
the name generic, as there could be other programs that pass over
sockets in a similar fashion, such as xinetd.  I could go with
:use-systemd-socket if you want, though?

> Oh, and you promised documentation...

Yes, sorry.  I realised when I sent the patch in that forgot about that.
I'll send over a final patch series that includes the docs, once we've
got the name sorted :-).

Thanks,
-- 
Matt