emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] Add systemd socket launching support


From: Matthew Leach
Subject: Re: [PATCH v3] Add systemd socket launching support
Date: Thu, 31 Mar 2016 17:38:51 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Hi Stefan,

Thanks for taking a look.

Stefan Monnier <address@hidden> writes:

>> Internally, sd_listen_fds() checks whether the $LISTEN_PID environment
>> variable equals the daemon PID. If not, it returns
>> immediately. Otherwise, it parses the number passed in the $LISTEN_FDS
>> environment variable, then sets the FD_CLOEXEC flag for the parsed
>> number of file descriptors starting from SD_LISTEN_FDS_START. Finally,
>> it returns the parsed number.
>
> Then I think it would be better to follow an approach like the one with
> which you started (i.e. without the internal systemd_socket variable),

Could I clarify, would you like me to expose these variables to lisp,
like I did in v1 of the patches?  Or make the internal variable names
non-systemd specific?
-- 
Matt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]