|
From: | Paul Eggert |
Subject: | Re: expose XHASH [patch] |
Date: | Thu, 31 Mar 2016 15:43:33 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 03/31/2016 12:29 PM, Paul Pogonyshev wrote:
Attached trivial patch just exposes internally used XHASH(), which fully suits this usecase.
Thanks, I like the overall idea but have some quibbles about the details.The documentation for the new function should be next to the documentation for sxhash.
Shouldn't we expose hashfn_eq, not XHASH? After all, (make-hash-table :test 'eq ...) uses hashfn_eq, not XHASH.
Should we also expose hashfn_eql, which is what make-hash-table uses by default? Or is that a waste of time since hashfn_eql is the default?
Not sure I like the name xhash. Maybe sxhash-eq instead? That would let us use the name sxhash-eql for hashfn_eql.
[Prev in Thread] | Current Thread | [Next in Thread] |