[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Undefined behavior in OS X unexec detected by ASan
|
From: |
Eli Zaretskii |
|
Subject: |
Re: Undefined behavior in OS X unexec detected by ASan |
|
Date: |
Fri, 08 Apr 2016 11:27:34 +0300 |
> From: Philipp Stephani <address@hidden>
> Date: Sat, 02 Apr 2016 17:26:17 +0000
>
> unexmacosx.c reads process memory directly, which tends to work in practice
> but is technically undefined
> behavior. I've attached a small patch that uses vm_read instead. According to
> ASan with this patch there's no
> more UB when dumping.
Would someone who uses OS X please see if this patch is OK? Are there
any version-related caveats here (e.g., could some older OS X version
have trouble with this change)?
If everything's fine with the patch, we still need to decide to which
branch this should go. John?