emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview fa


From: Stefan Monnier
Subject: Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face.
Date: Tue, 26 Apr 2016 09:51:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

>     Make use of rectangle-preview face.
    
>     * lisp/rect.el (rectangle--string-preview):
>     (rectangle--highlight-for-redisplay): Replace 'region with
>     'rectangle-preview (Bug#23248).

I think this patch went a bit overboard: `rectangle-preview' supposedly
refers to the text-preview in C-x r t, whereas the patch also uses
rectangle-preview when you're just selecting a rectangular region.

IOW, I think the part of the patch that touched
rectangle--string-preview was right, but the part that touched
rectangle--highlight-for-redisplay should be reverted.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]