[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview fa
|
From: |
Mark Oteiza |
|
Subject: |
Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face. |
|
Date: |
Tue, 26 Apr 2016 11:46:41 -0400 |
|
User-agent: |
Mutt/1.5.24+88 (2a73a6e7c6e7) (2015-08-30) |
On 26/04/16 at 09:51am, Stefan Monnier wrote:
> > Make use of rectangle-preview face.
>
> > * lisp/rect.el (rectangle--string-preview):
> > (rectangle--highlight-for-redisplay): Replace 'region with
> > 'rectangle-preview (Bug#23248).
>
> I think this patch went a bit overboard: `rectangle-preview' supposedly
> refers to the text-preview in C-x r t, whereas the patch also uses
> rectangle-preview when you're just selecting a rectangular region.
>
> IOW, I think the part of the patch that touched
> rectangle--string-preview was right, but the part that touched
> rectangle--highlight-for-redisplay should be reverted.
Thanks. Fixed in ccb75d72.