[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-m
|
From: |
Leo Liu |
|
Subject: |
Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string |
|
Date: |
Wed, 27 Apr 2016 22:23:16 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (OS X 10.11.4) |
On 2016-04-27 12:40 +0300, Dmitry Gutov wrote:
> Why was that bad?
>
> vc-working-revision also caches the result, and
> vc-git-working-revision does not. Do you want Emacs to call Git
> multiple times per second?
Thanks, I hadn't paid attention to the cache issue. I pushed a different
fix that doesn't bypass the cache.
We need to avoid deciding the backend at that point and
vc-git-mode-line-string expects REV to be non-nil or the substring form
will complain.
Leo