Re: [Emacs-diffs] master b9d6938: Cancel the eldoc timer when switching off eldoc mode

[Stefan Monnier]

>      (kill-local-variable 'eldoc-message-commands)
>      (remove-hook 'post-command-hook 'eldoc-schedule-timer t)
> -    (remove-hook 'pre-command-hook 'eldoc-pre-command-refresh-echo-area t))))
> +    (remove-hook 'pre-command-hook 'eldoc-pre-command-refresh-echo-area t)
> +    (when eldoc-timer
> +      (cancel-timer eldoc-timer)
> +      (setq eldoc-timer nil)))))
 
Hmm... IIUC the timer is global (i.e. shared by all buffers), whereas
the above code is run when disabling eldoc-mode in one
particular buffer.  So it doesn't look right.


        Stefan