emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master d05806f: alas, a map can have only one parent


From: Sam Steingold
Subject: Re: master d05806f: alas, a map can have only one parent
Date: Mon, 02 May 2016 12:28:49 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

> * Lars Ingebrigtsen <address@hidden> [2016-05-02 18:00:26 +0200]:
>
> Sam Steingold <address@hidden> writes:
>
>>     alas, a map can have only one parent
>>
>>     * lisp/image-mode.el (image-model-map): Cannot have two parents.
>>     * lisp/image.el (image-map): Inherit from `special-mode-map'.
>
> This is the definition of image-mode-map:
>
> (defvar image-mode-map
>   (let ((map (make-sparse-keymap)))
>   ...
>     (make-composed-keymap (list map image-map) special-mode-map))
>
> Which should take care of the multiple inheretance.
>
> And image-map should certainly not inherit anything from
> special-mode-map.
>
> So I think your patch is wrong.  What are you trying to fix?

`q' in image-mode was not bound.

-- 
Sam Steingold (http://sds.podval.org/) on Ubuntu 16.04 (xenial) X 11.0.11803000
http://www.childpsy.net/ http://truepeace.org http://iris.org.il
http://openvotingconsortium.org http://memri.org http://www.memritv.org
A computer scientist is someone who fixes things that aren't broken.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]