[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 81204b2: Port xref-tests to master branch
From: |
Paul Eggert |
Subject: |
Re: [Emacs-diffs] master 81204b2: Port xref-tests to master branch |
Date: |
Sat, 7 May 2016 13:32:08 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 |
Dmitry Gutov wrote:
> Does anyone have better suggestions than
>
> (defvar xref-tests-data-dir
> (expand-file-name "../../data/xref/"
> (file-name-directory (or load-file-name
> (buffer-file-name)))))
I don't know the test architecture well and don't have any better suggestion.
That being said, the master branch should use the same pattern for all the tests
that consult the data file. I adjusted the xref tests to use the pattern I saw
elsewhere; if the pattern is wrong, we should fix it everywhere. Extra points if
you can figure out how to fix it without breaking merges from the emacs-25
branch, which uses a slightly different architecture in this area.