[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Annotation] New package: smart-yank.el
From: |
Stefan Monnier |
Subject: |
Re: [Annotation] New package: smart-yank.el |
Date: |
Mon, 16 May 2016 20:38:23 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
> I intend to upload the attached package "smart-yank.el" to Gnu Elpa
> (does that work again btw?).
> Any comments, objections, ...or something like that? Thanks.
Sounds good to me. See nitpicks below.
Stefan
> (let ((r (smart-yank--stopwatch)))
> (defun smart-yank-yank-pop (&optional arg)
[...]
> (declare-function smart-yank-yank-pop 'smart-yank)
An arguably cleaner way to get the same result would be:
(defalias 'smart-yank-yank-pop
(let ((r (smart-yank--stopwatch)))
(lambda (&optional arg)
"blabla"
...)))
> (define-minor-mode smart-yank-mode
[...]
> :global t :keymap smart-yank-map
Please name the keymap `smart-yank-mode-map' and don't use the :keymap
argument at all.