emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-


From: Stefan Monnier
Subject: Re: [Emacs-diffs] master ff9ddda: Simplify pre-write-conversion for utf-8-hfs coding system
Date: Fri, 10 Jun 2016 11:54:59 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

>  ;; Pre-write conversion for `utf-8-hfs'.
>  (defun ucs-normalize-hfs-nfd-pre-write-conversion (from to)
> -  (let ((old-buf (current-buffer)))
> -    (set-buffer (generate-new-buffer " *temp*"))
> -    (if (stringp from)
> -        (insert from)
> -      (insert-buffer-substring old-buf from to))
> -    (ucs-normalize-HFS-NFD-region (point-min) (point-max))
> -    nil))
> +  (ucs-normalize-HFS-NFD-region (point-min) (point-max)))
 
Could you add a comment explaining why it's OK to ignore `from` and `to`
here (as well as rename those args to `_from` and `_to` to make it
clear to the byte-compiler that we purposefully ignore them)?


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]