Re: [PATCH] RFC: eldoc-documentation-functions hook

[Mark Oteiza]

On 12/06/16 at 02:24pm, Mark Oteiza wrote:
> ---
> 
> On 12/06/16 at 10:09am, Eli Zaretskii wrote:
> > > Date: Sun, 12 Jun 2016 02:12:29 -0400
> > > From: Mark Oteiza <address@hidden>
> > > 
> > > This is a draft patch changing eldoc-documentation-function into a hook
> > > variable, so instead of using add-function, one can instead use add-hook
> > > to control the behavior of eldoc.  It is backwards compatible.
> > 
> > Thanks.  Please be sure to update the ELisp manual accordingly.
> 
> <snip> changed the default value back to nil, since this isn't being
> unconditionally funcall'd anymore.

Ah, this was a mistake wrt backwards compatibility.  The default can be
changed sometime in the future, I suppose.

Also had to fix eldoc-supported-p...

> In the manual, it appears that the -functions suffix is to be used for
> abnormal hooks; however this is a normal hook, so it would seem the name
> should use the -hook suffix.

... but I'll wait for some judgement on this before sending another
patch.