Re: Viper tests failure?

[Phillip Lord]

Eli Zaretskii <address@hidden> writes:

>> From: address@hidden (Phillip Lord)
>> Cc: address@hidden,  address@hidden
>> Date: Tue, 21 Jun 2016 21:26:58 +0100
>> 
>> > --- a/test/lisp/emulation/viper-tests.el
>> > +++ b/test/lisp/emulation/viper-tests.el
>> > @@ -38,7 +38,7 @@ viper-test-undo-kmacro
>> >          ;; Select an expert-level for the same reason.
>> >          (viper-expert-level 5)
>> >          ;; viper loads this even with -q so make sure it's empty!
>> > -        (viper-custom-file-name (make-temp-file "viper-tests"))
>> > +        (viper-custom-file-name (make-temp-file "viper-tests" nil ".elc"))
>> >          (before-buffer (current-buffer)))
>> >      (unwind-protect
>> >          (progn
>> The viper-test is fix obviously fine by me -- should have done it that
>> way in the first place, although uncovering the Fload but is a nice side
>> effect.
>
> I have now fixed this properly in Fload on master.  No change in
> viper-tests is necessary.

I'd probably change it anyway, to make it clearer in the test that this
is an (empty) load file.


>> Can you add it to emacs-25
>
> Doesn't sound like a good idea: the changes are not really trivial,
> and this problem has been with us for so long that one more release is
> not an issue.

Apologies, I mean fix the test. I guess there is no problem with making
a change to test on emacs-25. It's also necessary to stop the test error
as the Fload fix is on master.

Phil