Fwd: Crappyness of Emacs Version 24.5.1 defadvice

[Andreas Röhler]

Hi,

have a function which needs to trigger some cleanup when done - removing temporary files.

Understand it being a case to advice it. As we have some users with Emacs 23 still

a change in advice.el of Emacs 24.4 goes into the way.

Forward this message, as there seem to be others too stumbling over this.
Also reading in NEWS.24

** `defadvice' does not honor the `freeze' flag and cannot advise
special-forms any more.

Maybe switching back might not break anything and being recommendable?

There exists nadvice.el still for the folks needing the most advanced.

Just a question,

Andreas

-------- Forwarded Message --------

Subject:	Crappyness of Emacs Version 24.5.1 defadvice
Date:	Sun, 26 Jun 2016 22:46:09 -0700 (PDT)
From:	Davin Pearson <address@hidden>
To:	address@hidden
Newsgroups:	gnu.emacs.help

I have recently upgraded Emacs Version 24.5.1

emacs-24.5-bin-i686-mingw32.zip

I have a bunch of defadvice forms for implementing a d-speedbar
feature that is superior to the built in speedbar feature.

(defadvice describe-mode (around d-speedbar activate)
  (delete-other-windows)
  ad-do-it)

C-h f describe-mode RET says:

:around advice: `ad-Advice-describe-mode'

it used to say:

:around advice: d-speedbar

The old behavior is preferable so I know which file the advice
is coming from.