emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compilation warnings in mouse.el


From: Eli Zaretskii
Subject: Re: Compilation warnings in mouse.el
Date: Tue, 12 Jul 2016 08:04:57 +0300

> From: Stephen Berman <address@hidden>
> Cc: address@hidden
> Date: Mon, 11 Jul 2016 23:55:55 +0200
> 
> >   mouse.el:541:1:Warning: defcustom for 
> > `mouse-select-region-move-to-beginning'
> >       fails to specify containing group
> >   mouse.el:541:1:Warning: defcustom for 
> > `mouse-select-region-move-to-beginning'
> >       fails to specify containing group
> 
> Sorry about that.  I saw that the other defcustoms in mouse.el have a
> ":group 'mouse" line and wrongly assumed this group was defined.  So
> should I just add ":group 'mouse" to that defcustom or instead add a
> defgroup to mouse.el and remove the existing ":group 'mouse" lines?

Unlike Stefan, I think we should add :group to every defcustom.
Having them mysteriously missing from some of them is a time bomb:
remove or add enough defcustoms in the same file, and you have a bug.

Are there any downsides to having :group in all defcustoms?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]