Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook

[Leo Liu]

On 2016-07-09 20:27 -0400, Stefan Monnier wrote:
> A *-function variable is not an advice, but a hook.
>
> It's a different kind of hook than those manipulated by add-hook (which
> have names ending in -hook or -functions), but it's still a hook and
> those have been used for many years in various parts of Emacs.
>
> It just so happens that the operations that can manipulate those hooks
> conveniently (add-function/remove-function) are provided in the same
> file as the new advice-add, but that's only because it was convenient
> and natural to implement advice-add on top of those new operations.

May we have this incompatible change reverted?

Thanks,
Leo