[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: On controlling rectangle-preview
From: |
Mark Oteiza |
Subject: |
Re: On controlling rectangle-preview |
Date: |
Wed, 20 Jul 2016 19:00:47 -0400 |
User-agent: |
Mutt/1.6.2+18 (69bbe4da959f) (2016-07-01) |
On 20/07/16 at 08:37am, Stefan Monnier wrote:
> > To me that seems a little odd (unexpected behaviour),
>
> Hmm... I can see that.
>
> > and with an empty minibuffer the default preview is only an M-n away.
>
> Good point. So I think your patch is OK as is, tho I'm not sure the
> custom variable is worth the trouble.
Sounds good to me, thanks.
This ends up bring very simple--permission to push to emacs-25?
diff --git a/lisp/rect.el b/lisp/rect.el
index 8803a47..a86d155 100644
--- a/lisp/rect.el
+++ b/lisp/rect.el
@@ -410,9 +410,6 @@ rectangle-preview
(defun rectangle--string-preview ()
(when rectangle-preview
(let ((str (minibuffer-contents)))
- (when (equal str "")
- (setq str (or (car-safe minibuffer-default)
- (if (stringp minibuffer-default) minibuffer-default))))
(when str (setq str (propertize str 'face 'rectangle-preview)))
(with-selected-window rectangle--string-preview-window
(unless (or (null rectangle--string-preview-state)
- On controlling rectangle-preview, Mark Oteiza, 2016/07/19
- Re: On controlling rectangle-preview, Stefan Monnier, 2016/07/19
- Re: On controlling rectangle-preview, Mark Oteiza, 2016/07/19
- Re: On controlling rectangle-preview, Stefan Monnier, 2016/07/20
- Re: On controlling rectangle-preview,
Mark Oteiza <=
- Re: On controlling rectangle-preview, John Wiegley, 2016/07/21
- Re: On controlling rectangle-preview, Eli Zaretskii, 2016/07/21
- Message not available
- Message not available
- Re: On controlling rectangle-preview, Mark Oteiza, 2016/07/21
- Re: On controlling rectangle-preview, Stefan Monnier, 2016/07/21
- Re: On controlling rectangle-preview, Eli Zaretskii, 2016/07/21
- Re: On controlling rectangle-preview, Mark Oteiza, 2016/07/21