Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el)

[Eli Zaretskii]

> Date: Sat, 13 Aug 2016 14:18:32 -0400
> From: Mark Oteiza <address@hidden>
> Cc: address@hidden, John Wiegley <address@hidden>,
>       Eli Zaretskii <address@hidden>
> 
> On 10/08/16 at 10:36pm, Stefan Monnier wrote:
> > > Seems like a lot of low hanging fruit to pick and I should post
> > > a patch, WDYT?
> > 
> > Go for it.
> 
> Done.  Flipped the switch and fixed small warnings on files in
> lisp/*.el, but didn't bother with fixing other kinds of warnings or
> altering libs actually using dynamic binding or didn't already have
> a compile-time dependency on cl{,-lib} for {,cl-}pushnew.  Nothing
> appears to be broken, but AFAIK I don't make regular use of many of
> these libraries.

IMO, we should have tests for each one of them before we do this.

Thanks.