Re: [Emacs-diffs] master 4ffdcfc: Nudge WoMan toward lexical-binding

[Stefan Monnier]

> -                   (add-to-list 'manpath
> -                                (if (match-beginning 1)
> -                                    (match-string 1)
> -                                  (cons (match-string 2)
> -                                        (match-string 3)))))
> +                      (cl-pushnew (if (match-beginning 1)
> +                                      (match-string 1)
> +                                    (cons (match-string 2)
> +                                          (match-string 3)))
> +                                  manpath))

cl-pushnew uses `eql` (contrary to add-to-list which uses `equal`) for
equality testing.  So when applied to value that have just been
constructed by `cons` and `match-string`, it will do exactly the same as
`push` would.

IOW I think you need to add

    :test #'equal

as arg to many of those cl-pushnew you introduced.  Note that in my
experience there are also some `add-to-list`s which don't actually care
about equality testing at all and can just be replaced by a simple
`push`.


        Stefan