emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enable customisation for electric-quote-mode chars


From: Göktuğ Kayaalp
Subject: Re: [PATCH] Enable customisation for electric-quote-mode chars
Date: Mon, 29 Aug 2016 20:19:34 +0300

> From: Eli Zaretskii <address@hidden>
> Date: 2016-08-29 07:39:32 PM +0300
> Eli Zaretskii wrote:
>> From: Göktuğ Kayaalp <address@hidden>
>> Cc: address@hidden, address@hidden
>> Date: Mon, 29 Aug 2016 19:27:42 +0300
>> 
>> > From: Eli Zaretskii <address@hidden>
>> > Date: 2016-08-29 06:08:25 PM +0300
>> > Eli Zaretskii wrote:
>> >> From: Göktuğ Kayaalp <address@hidden>
>> >> Cc: address@hidden, address@hidden
>> >> Date: Mon, 29 Aug 2016 08:28:19 +0300
>> 
>> (I'm sorry for /borrowing/ your citation style, but it's very nice, I
>> couldn't refuse.  Hope that doesn't annoy you :)  I've made it a bit
>> different though.)
>
> It's not me, it's Rmail that's doing this.  (No, I'm not annoyed, of
> course not.)

I use rmail too, but I had already my cit. line customized some time ago
when I used Gnus, so I didn't se this format until now.

I'll wait and follow the thread for at least a couple days for comments,
and if I don't have the chance earlier, I'll post an updated patch on
Saturday.

>> >> +quote characters.  It's possible to change the default quotes listed
>> >> +above, by customizing the variable @code{electric-quote-chars}, a list
>> >> +of four characters, where the items correspond to the left single
>> >> +quote, the right single quote, the left double quote and the right
>> >> +double quote, respectively, whose default value is
>> >> address@hidden'(?‘ ?’ ?“ ?”)}.
>> >
>> > There's no need to go to such detail when describing a customizable
>> > option.  The Customize interface should be enough for the user to
>> > figure out what to do.
>> 
>> Then I can remove the part after reference to the variable name, and
>> improve the defcustom's documentation (see below).  Is that okay?
>
> Yes.
>
>> >   Default (‘..’ “..”)
>> >   Arabic (".." ”..“)
>> >   German  (‚..‛ „..“)
>> >   French (‹..› «..»)
>> >   Cyrillic (‚..‘ «..»)
>> >
>> > etc.  WDYT?  (See https://en.wikipedia.org/wiki/Quotation_mark for
>> > some more.)
>> 
>> Well I think we'd rather not do that but improve the docstring instead,
>> because, looking at the big summary table on the page you linked [1]
>> there's not only a lot of variance among languages, but some of them
>> have multiple standard and alternative forms, and some don't have single
>> quotes (e.g. Persian).  I think we'd better keep the defaults and
>> improve the documentation, and not have implement all the languages nor
>> have to pick a subset.
>
> If no one else thinks my suggestion is a significant improvement, I
> won't insist.  (And of course, we don't need to implement the entire
> Wikipedia list, I'm not even sure it's accurate.)
>
> It could be enough to mention some of the possibilities in the doc
> string, together with their cultural affiliations.
>
>> Maybe we could leave setting these variables to the language environment
>> if that's possible?
>
> I think it's too early for that, we haven't yet figured out how to set
> up language dependent settings.  One problem with the idea you raise
> is that a user can reside in a certain locale, but use universal
> settings commonly used in multilingual environments.
>
>> Please direct me on how to proceed, and I'll update the patch as soon as
>> I can
>
> I would suggest to wait for a couple of days for more comments.  If no
> one supports my suggestions about language-tagged alternatives, you
> can disregard them, and only make the documentation changes already
> mentioned.
>
> Thanks.
>

Best,
-goktug.

-- 
İ. Göktuğ Kayaalp.
http://gkayaalp.com/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]