[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Don't complain about changed file when it hasn't changed
From: |
Eli Zaretskii |
Subject: |
Re: Don't complain about changed file when it hasn't changed |
Date: |
Thu, 01 Sep 2016 16:49:47 +0300 |
> From: Stefan Monnier <address@hidden>
> Date: Tue, 30 Aug 2016 14:06:02 -0400
>
> >> So if you want to "update the doc" here, we'd have to actually state
> >> what the standard definition does (we currently don't do actually that).
>
> > ... indeed we should state that, because otherwise a naïve user will
> > not understand how come she lost this nice feature by just replacing a
> > function that is supposed to ask a question and be done.
>
> OK, I can do that.
Thanks.
> Of course, this begs another question: should the new test be in
> ask-user-about-supersession-threat or in its caller? I placed it in
> ask-user-about-supersession-threat for no very good reason (tho I don't
> see any strong reasons to move it to the caller either).
My preference would be to have the test in the caller, because I doubt
that anyone who replaces that function would want to lose the test.
But that preference is not very strong.