[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master ca47390: image-dired: Report when a necessary executable is n
|
From: |
Clément Pit--Claudel |
|
Subject: |
Re: master ca47390: image-dired: Report when a necessary executable is not found |
|
Date: |
Mon, 5 Sep 2016 00:42:23 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 2016-09-04 23:42, Tino Calancha wrote:
> Please let me know if the following patch is OK:
> …
> (defcustom image-dired-cmd-create-thumbnail-program
> - "convert"
> + (executable-find "convert")
> …
> (defcustom image-dired-cmd-create-thumbnail-program
> - (executable-find "convert")
> + (when (executable-find "convert") "convert")
I don't understand how these two consecutive patches works. Assume I don't
have "convert". Before the patches Emacs would complain, and installing
ImageMagick would fix the complaint. After, Emacs will complain about not
finding "convert", but after I install ImageMagick Emacs will keep complaining,
because the defcustom will still be nil. Is this intended? Or am I
misunderstanding something?
Cheers,
Clément.
signature.asc
Description: OpenPGP digital signature