emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.


From: Toke Høiland-Jørgensen
Subject: Re: [PATCH] url: Wrap cookie headers in url-http--encode-string.
Date: Thu, 08 Sep 2016 19:43:41 +0200

Eli Zaretskii <address@hidden> writes:

>> From: Toke Høiland-Jørgensen <address@hidden>
>> Cc: Eli Zaretskii <address@hidden>, address@hidden, address@hidden
>> Date: Thu, 08 Sep 2016 17:58:31 +0200
>> 
>> (url-retrieve-synchronously "http://google.se";) ; sets a cookie
>> (let* ((url-request-data (encode-coding-string "æøå" 'utf-8)))
>>        (url-retrieve-synchronously "http://google.se";)) ; crashes
>
> Can the cookies file include non-ASCII text?  E.g., could the domain
> be non-ASCII?

>From glancing at the code, it seems those are the non-puny-coded
hostnames that are stored in that file. But that doesn't really matter,
as those are only lookup variables in an the array. The question is
whether the cookie values themselves can be. As for that, well...:

http://stackoverflow.com/questions/1969232/allowed-characters-in-cookies

My reading of that is in most cases they will be. But really, it depends
on what the url code itself accepts; of which I have no idea.

-Toke



reply via email to

[Prev in Thread] Current Thread [Next in Thread]