[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] xwidget webkit: Use WebKit2 API.
From: |
joakim |
Subject: |
Re: [PATCH 0/6] xwidget webkit: Use WebKit2 API. |
Date: |
Wed, 21 Sep 2016 14:05:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Ricardo Wurmus <address@hidden> writes:
> O fellow humans on emacs-devel!
>
> I noticed that for the embedding of a WebKit widget in Emacs an old
> version of WebKitGtk is needed, because the code in "src/xwidget.c"
> targets the WebKit1 API. As far as I know, only the latest version of
> WebKitGtk is actively maintained, so it seems like a good idea to make
> Emacs work with the latest version.
I haven't had a chance to try this yet, but I'm very happy that you are
working on this!
>
> The first patch in this series adjusts the code such that the WebKit2
> API is used instead, which allows users to build Emacs with the latest
> version of WebKit(2)Gtk. Due to process separation in WebKit2Gtk,
> scrolling is now supposed to be done in the UI process. This is what
> the second patch does; it implements scrolling by executing JavaScript
> in the WebKit view. (Maybe the first two commits should be squashed?)
>
> The other patches are simple changes to make interacting with the
> WebKit widget a little easier.
>
> If these patches are okay I'd like to continue by removing the title
> hack, which is currently used to get a stringified return value from
> JavaScript. This is no longer needed when using the WebKit2 API as it
> supports passing a callback to process any JS return values.
Indeed the title hack is horrible, and I'm glad you have found a better
solution.
> ~~ Ricardo
>
> PS: I did copyright assigment for GNU Guile already, but I'm not sure
> if copyright assignment is on file for Emacs already.
>
> Ricardo Wurmus (6):
> xwidget: Use WebKit2 API
> Remove scrolled window container around WebKit widget
> Implement zoom for WebKit widget.
> xwidget: Bind "beginning-of-buffer" and "end-of-buffer"
> Let initial WebKit view fill window
> xwidget: Map "previous-line" and "next-line" to scroll
>
> configure.ac | 4 +-
> lisp/xwidget.el | 56 +++++++++---
> src/xwidget.c | 270
> ++++++++++++++++++++++----------------------------------
> src/xwidget.h | 3 -
> 4 files changed, 151 insertions(+), 182 deletions(-)
--
Joakim Verona
- [PATCH 0/6] xwidget webkit: Use WebKit2 API., Ricardo Wurmus, 2016/09/21
- [PATCH 1/6] xwidget: Use WebKit2 API, Ricardo Wurmus, 2016/09/21
- [PATCH 2/6] Remove scrolled window container around WebKit widget, Ricardo Wurmus, 2016/09/21
- [PATCH 3/6] Implement zoom for WebKit widget, Ricardo Wurmus, 2016/09/21
- [PATCH 4/6] xwidget: Bind "beginning-of-buffer" and "end-of-buffer", Ricardo Wurmus, 2016/09/21
- [PATCH 5/6] Let initial WebKit view fill window, Ricardo Wurmus, 2016/09/21
- [PATCH 6/6] xwidget: Map "previous-line" and "next-line" to scroll, Ricardo Wurmus, 2016/09/21
- Re: [PATCH 0/6] xwidget webkit: Use WebKit2 API.,
joakim <=
- Re: [PATCH 0/6] xwidget webkit: Use WebKit2 API., Eli Zaretskii, 2016/09/21