emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isea


From: Eli Zaretskii
Subject: Re: [Emacs-diffs] emacs-25 197a6bc: Fix horizontal scrolling during Isearch
Date: Sat, 08 Oct 2016 18:57:32 +0300

> From: Stefan Monnier <address@hidden>
> Date: Sat, 08 Oct 2016 11:43:11 -0400
> 
> >> >     * lisp/isearch.el (isearch-update): Compute the window's body
> >> >     width in a way that is correct when there are no fringes.
> >> >     (Bug#24584)
> >> [...]
> >> > -                    (>= (car visible-p) (window-body-width nil t)))
> >> > +                    (>= (car visible-p)
> >> > +                        (* (window-max-chars-per-line) 
> >> > (frame-char-width))))
> >> 
> >> Hmm... shouldn't window-body-width return the right answer even when
> >> there are no fringes?
> > We were too afraid to make that change at the time, because some
> > callers don't (or might not) want that.
> 
> Ah, so this is only for the emacs-25 branch, and on master we'll have
> "the right fix" instead?

Not necessarily, see

  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22891#59

Volunteers are welcome to review the users of window-body-width and
suggest which ones to convert.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]