Re: Patches for Emacs 25.2

[Michael Albinus]

Dmitry Gutov <address@hidden> writes:

> On 07.11.2016 11:01, Michael Albinus wrote:
>
>>> Can't we move the (file-remote-p ... 'localname) call to the first
>>> hunk here? Then the patch will only change one place, and we get rid
>>> of the added `or' here.
>>
>> I let it to Nikolay.
>
> Not sure I understand.

The patch for the emacs-25 branch is proposed by Nikolay.

>> However, given that this construct
>>
>>   (or (file-remote-p FILE 'localname) FILE)
>>
>> happens several times in the lisp sources, I wonder whether we shall
>> give it an own defmacro or defsubst (in master, of course).
>
> I have no strong opinion either way, but your commit in master fixing
> this problem does not have this construct.

Sure. It was a rather general comment, given that we find this construct
under .../emacs/lisp for at least 11 times, and under .../elpa 4 times.

Best regards, Michael.