[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] assq-delete-all, rassq-delete-all: Avoid duplication of code
|
From: |
Clément Pit--Claudel |
|
Subject: |
Re: [PATCH] assq-delete-all, rassq-delete-all: Avoid duplication of code |
|
Date: |
Mon, 28 Nov 2016 13:17:08 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 2016-11-28 12:24, Eli Zaretskii wrote:
>> From: Tino Calancha <address@hidden>
>> Date: Mon, 28 Nov 2016 18:52:36 +0900
>> Cc: address@hidden
>>
>> how about following patch?
>> It prevent some duplication of code in subr.el, and it adds
>> a new test.
>
> What about the overhead of a function call? These functions are
> likely to be invoked in loops.
>
> Should we make the common part a defsubst?
Would defsubst be enough? I think you'd want a defmacro. Otherwise, you'll
still pay for all the funcalls to #'car and #'cdr, won't you?
signature.asc
Description: OpenPGP digital signature