emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master ba07fd7: New package: json-mode


From: Simen Heggestøyl
Subject: Re: [elpa] master ba07fd7: New package: json-mode
Date: Fri, 16 Dec 2016 17:09:42 +0100

Hi Stefan, thanks for your comments.

On Sun, Dec 11, 2016 at 6:03 PM, Stefan Monnier <address@hidden> wrote:
Would it make sense to inherit some things (such as the syntax-table)
from js-mode?

JSON's syntax is a subset of the JavaScript syntax, so I think it would
make sense. On the other hand, the JSON syntax is very simple, and
js-mode currently uses cc-mode to produce a syntax table which contains
much more than json-mode needs, so maybe it's OK to just define what we
need in json-mode. What do you think?

Are these meant to match strings that span several lines?
If no, the regexps are wrong (because they can match multiple lines).
If yes, this will fail in various circumstances
(see (info "(elisp)Font Lock Multiline") for more details).

No. They're removed in the proposed diff.

Why not do something like [...]

Looks good to me. See the attached diff.

-- Simen

Attachment: 0001-WIP.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]