emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile


From: Jackson Ray Hamilton
Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile
Date: Sun, 18 Dec 2016 18:43:53 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1

Would you be amenable to me pushing the attached patch?

Jackson

On 12/17/2016 07:18 PM, Stefan Monnier wrote:
>> Apparently, tar uses gnulib's excluded_file_name function, which appears
>> to delegate to fnmatch, which looks pretty complex to me.  I'm not aware
>> of a "standalone" command providing an interface for this pattern
>> matcher, but if one exists, maybe we could utilize that.
> 
> I think we could use sh's "case" patterns for that.
> 
>> Another option might be to generate an archive with tar and then use the
>> list of included files to determine what to compile.  This command:
>>
>> $ tar -ch packages/context-coloring/ --exclude-vcs -X \
>>   packages/context-coloring/.elpaignore | tar --list
>>
>> Produces this output:
> 
>> packages/context-coloring/
>> packages/context-coloring/LICENSE
>> packages/context-coloring/context-coloring-emacs-lisp.el
>> packages/context-coloring/README.md
>> packages/context-coloring/context-coloring-javascript.el
>> packages/context-coloring/context-coloring.el
>>
>> We could filter down the ".el" files from there.
> 
> That might work as well, indeed.
> 
> BTW, given the current GNUmakefile, it's easy/natural to only test
> .elpaignore matches for those files which end in .el and which don't yet
> have a .elc file.  I expect this would be an important optimization to
> make sure that "make" is fast when there's not much to (re)compile.
> 
> 
>         Stefan
> 

Attachment: 0001-Respect-.elpaignore-when-determining-files-to-byte-c.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]