emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix RefTeX to show table of contents for dtx files


From: Tassilo Horn
Subject: Re: [PATCH] Fix RefTeX to show table of contents for dtx files
Date: Mon, 02 Jan 2017 13:22:57 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Sašo Živanović <address@hidden> writes:

Hi Sašo,

> I've fixed a tiny bug in RefTeX: TOC was not shown for dtx files.

Good catch, thanks!

I've committed your patch with a slight modification.  Instead of this

> -                 (when toc-entry
> +                 (when (and toc-entry
> +                            (equal
> +                             (equal (char-after bound) ?%)
> +                             (string-suffix-p ".dtx" file)
> +                             ))

I used

                   (when (and toc-entry
                            (eq ;; Either both are t or both are nil.
                             (= (char-after bound) ?%)
                             (string-suffix-p ".dtx" file)))

which looks a bit more clear to me.

I've seen that this is your first patch to Emacs, and given that it's
less than 15 lines of code, I can commit it for you as-is.  However, if
you plan to contribute more in the future, a copyright assignment will
be due.

Bye,
Tassilo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]