Re: [PATCH] Fix RefTeX to show table of contents for dtx files

[Sašo Živanović]

Hi Tassilo!

Thanks for the prompt reply and commit!

On 02. 01. 2017 13:22, Tassilo Horn wrote:
> Sašo Živanović <address@hidden> writes:
>
> Hi Sašo,
>
> > I've fixed a tiny bug in RefTeX: TOC was not shown for dtx files.
>
> Good catch, thanks!
>
> I've committed your patch with a slight modification.  Instead of this
>
> > -                 (when toc-entry
> > +                 (when (and toc-entry
> > +                            (equal
> > +                             (equal (char-after bound) ?%)
> > +                             (string-suffix-p ".dtx" file)
> > +                             ))
>
> I used
>
>                    (when (and toc-entry
>                             (eq ;; Either both are t or both are nil.
>                              (= (char-after bound) ?%)
>                              (string-suffix-p ".dtx" file)))
>
> which looks a bit more clear to me.
Fine with me. You see that my lisp is pretty rudimentary ...

> I've seen that this is your first patch to Emacs, and given that it's
> less than 15 lines of code, I can commit it for you as-is.  However, if
> you plan to contribute more in the future, a copyright assignment will
> be due.
Gladly.

Best,
Sašo

> Bye,
> Tassilo