Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466)

[Eli Zaretskii]

> From: Juri Linkov <address@hidden>
> Cc: address@hidden,  address@hidden
> Date: Fri, 14 Apr 2017 02:35:08 +0300
> 
> > Alas, a couple of users of kill-this-buffer were sometimes calling it
> > in the context of a menu-invoked command, so that part still can make
> > sense.  And I have no idea which of the callers relied on this feature
> > even when invoking the function via non-menu events.  It's been 9
> > years since this feature was introduced.
> 
> I'm sure that all these callers used kill-this-buffer because there was no
> kill-current-buffer to simply kill the current buffer, and nothing more.

I'm sure we have no idea whether we can be sure.

After so many years that this code existed, I see no reason to rock
the boat now.  This bike shed's color was fixed long ago; if we didn't
care during all these years, we should definitely leave it at that
now.

All I did was to add a simple sentence to the doc string, something
that was over the years requested a couple of times, with no-one
bothering to do anything, not even reply.  And look what tempest did
this small change cause!  I wonder why.

> So I think we need to leave kill-this-buffer callers only in 
> menu-bar/tool-bar,
> and use kill-current-buffer everywhere else, leaving just
> ‘(kill-buffer (current-buffer))’ in the definition of
> kill-current-buffer in simple.el.

Sorry, I disagree.