Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466)

[Stefan Monnier]

>> By this measure, we can stop hacking on Emacs,
> Not hacking, only bike-shedding.

To me bike-shedding means that it's only an aesthetic issue, but in this
case the ugliness has enough real consequences that you felt compelled
to document them via:

    diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
    index 208f4c2..1594270 100644
    --- a/lisp/menu-bar.el
    +++ b/lisp/menu-bar.el
    @@ -1904,7 +1904,10 @@ updating the menu."
     (defun kill-this-buffer () ; for the menu bar
       "Kill the current buffer.
     When called in the minibuffer, get out of the minibuffer
    -using `abort-recursive-edit'."
    +using `abort-recursive-edit'.
    +
    +This command can be reliably invoked only from the menu bar,
    +otherwise it could decide to silently do nothing."
       (interactive)
       (cond
        ;; Don't do anything when `menu-frame' is not alive or visible

My patch (as fixed by Martin) fixes the problem instead of documenting
the resulting quirks.  While it's not terribly important, it's not
just cosmetic.


        Stefan