emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Integrate module test with normal test suite


From: Eli Zaretskii
Subject: Re: [PATCH] Integrate module test with normal test suite
Date: Sat, 22 Apr 2017 17:47:55 +0300

> From: Philipp Stephani <address@hidden>
> Date: Sat, 22 Apr 2017 16:23:27 +0200
> Cc: Philipp Stephani <address@hidden>
> 
> +$(test_module): $(srcdir)/../src/emacs-module.[ch]
> +     $(MAKE) -C $(test_module_dir) $(test_module_name) \
> +       SO=$(patsubst .%,%,@MODULES_SUFFIX@)

Can we get rid of the patsubst thing, please?  It makes little sense
to assume in the Makefile that SO doesn't include the leading period,
only to have to delete it from the value computed by configure.

Also, I believe you need to quote the string after SO=, as it includes
whitespace.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]