Re: lisp/term/ns-win.el modification

[Anders Lindgren]

Hi!

I just pushed this to the master brach.

Congratulations to your first Emacs contribution!

    -- Anders

On Thu, May 4, 2017 at 10:50 AM, Jean-Christophe Helary <address@hidden> wrote:

Anders,

Thank you for the verification. Would you mind checking that this patch is correct before I propose it for a commit?

The log message would be something like:

===========================
Fix Multiline support in NS "open-file" service previous patch

* lisp/term/ns-win.el (ns-open-file-service): removed a useless check and fixed a typo.
===========================

Jean-Christophe



> On May 4, 2017, at 5:40, Anders Lindgren <address@hidden> wrote:
>
> Hi!
>
> I just tested your latest patch. The code looks much cleaner now when you use `split-string'. (I didn't know it could all those tricks -- it's always good to learn something new!)
>
> The patch seems to work perfectly!
>
> Some minor details:
>
> * You no longer need the `(if (not (equal "" filestring"))' test -- when the OMIT-NULLS argument is non-nil, `split-string' ensures that the list doesn't contain empty strings.
>
> * You misspelled "trimmed" as "timmed" in the comment in `ns-open-file-service'.
>
>    -- Anders