emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 583995c: GnuTLS HMAC and symmetric cipher support


From: Paul Eggert
Subject: Re: master 583995c: GnuTLS HMAC and symmetric cipher support
Date: Mon, 17 Jul 2017 17:59:10 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

Glenn Morris wrote:
It's OK, as every cipher other than GNUTLS_CIPHER_NULL has a non-NULL name.
But it isn't OK. That's what this thread is about.
GNUTLS_CIPHER_UNKNOWN apparently has a NULL name.

Sorry, I still don't see the problem here. From what I can see, GNUTLS_CIPHER_NULL is not a cipher (or to be more precise, it is not a valid GnuTLS cipher ID). The code in question:

const gnutls_cipher_algorithm_t *gciphers = gnutls_cipher_list ();
for (ptrdiff_t pos = 0; gciphers[pos] != GNUTLS_CIPHER_NULL; pos++)
{
  gnutls_cipher_algorithm_t gca = gciphers[pos];
  Lisp_Object cipher_symbol = intern (gnutls_cipher_get_name (gca));

looks only at GnuTLS cipher IDs returned by gnutls_cipher_list, and GNUTLS_CIPHER_UNKNOWN is not one of those cipher IDs.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]