Re: [PATCH] lcms2 (was Re: Emacs 26.1 release branch created)

[Eli Zaretskii]

> Date: Fri, 29 Sep 2017 16:25:40 -0400
> From: Mark Oteiza <address@hidden>
> Cc: address@hidden
> 
> Here is the patch I thought I would not get done.

Thanks, it looks good (didn't try to build it, though).

> * src/lcms.h: New file.

Not sure why you needed a header file.  Do you envision the struct
defined in it to be used elsewhere in Emacs sources?  If not, you can
define the struct in lcms.c instead.

> +static void
> +jch_to_xyz (const cmsJCh *jch, cmsCIEXYZ *xyz, const cmsViewingConditions 
> *vc)
> +{
> +  cmsHANDLE h;
> +
> +  h = cmsCIECAM02Init (0, vc);
> +  cmsCIECAM02Reverse (h, jch, xyz);
> +  cmsCIECAM02Done (h);
> +}

cmsCIECAM02Reverse was not used previously, so it will have to be
added to the WINDOWSNT parts.  Let me know if you want me to send a
patch for that.

> +  double Mp = sqrt (jab->a * jab->a + jab->b * jab->b);

I'd use 'hypot' here, it's supposed to be more accurate and avoids
overflow/underflow for large or small a and b.  Or are we sure a and b
are always confined to some small range of values?