[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to
|
From: |
Alan Mackenzie |
|
Subject: |
Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes |
|
Date: |
Wed, 11 Oct 2017 20:02:12 +0000 |
|
User-agent: |
Mutt/1.7.2 (2016-11-26) |
Hello, Stefan.
On Mon, Oct 09, 2017 at 00:13:24 -0400, Stefan Monnier wrote:
> > address@hidden edebug-after-instrumentation-functions
> > +An abnormal hook run by Edebug after it instruments a form.
> > +Each function is called with one argument, a form which has
> > +just been instrumented by Edebug.
> This seems a bit awkward.
Why? How is it at all awkward?
> How 'bout something like the 100% untested patch below?
You don't say why you want to make the patch. It looks to me like you
want to replace a normal abnormal hook with a single function. This is
less flexible (unless one jumps through hoops). It is also
incompatible; it will break applications which use the existing
interface.
Why do you want to break these applications? What benefits will the
new single function scheme bring?
I'm against this incompatible change (which I don't fully understand).
> Stefan
[ .... ]
--
Alan Mackenzie (Nuremberg, Germany).