emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Something weird with when-let*/if-let*


From: Eric Abrahamsen
Subject: Re: Something weird with when-let*/if-let*
Date: Sun, 15 Oct 2017 20:23:20 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> Besides message.el, nnimap.el is the only gnus lib to use when-let*.
>> I can just add another subr-x require in nnimap for now -- if it starts
>
> That's indeed what should be done, regardless of what message.el does:
> if a foo.el uses a macro defined in bar.el, it should generally require
> that bar.el directly rather than rely on some toto.el file to load it.
>
> I'm not saying that we follow this rule all the time, but in my
> experience, this is a sane rule to follow.  The downside is really
> negligible: if foo.el requires foo.el which also requires bar.el, the
> extra/redundant (require 'bar) will cost very little anyway.

Done!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]