emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wait_reading_process_ouput hangs in certain cases (w/ patches)


From: Stefan Monnier
Subject: Re: wait_reading_process_ouput hangs in certain cases (w/ patches)
Date: Thu, 23 Nov 2017 21:31:08 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> I absolutely agree but quite honestly I was convinced I would get
> negative feedback if I did put it in a function of its own, given
> how the rest of wait_... looked and in general. So I went with the
> duplicated code for exactly that reason.

Many Emacs functions (especially in the C code) are much too large.
Don't take this as a hint that your code should aim for functions to be
as long as possible.
On the contrary, making them shorter by moving some of their code to
separate functions is welcome.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]