Re: [Emacs-diffs] master 52cc9a5: Reimplement inline functions in ERC with define-inline.

[Stefan Monnier]

>> > -(defsubst erc-get-server-user (nick)
>> > +(define-inline erc-get-server-user (nick)
>> >    "Find the USER corresponding to NICK in the current server's
>> >  `erc-server-users' hash table."
>> > -  (erc-with-server-buffer
>> > -    (gethash (erc-downcase nick) erc-server-users)))
>> > +  (inline-quote (erc-with-server-buffer
>> > +               (gethash (erc-downcase ,nick) erc-server-users))))
>> This will evaluate `nick` in another buffer than the caller's
>> current-buffer, so if the argument refers to buffer-local variables the
>> result may be different when inlined than it would be when not inlined.
> I'm not entirely sure on how to fix this. Would reverting to defsubst/defun be
> the only solution?

inline-letevals will do the trick (because you can put it outside of the
`erc-with-server-buffer`).


        Stefan