emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: windows installer


From: Phillip Lord
Subject: Re: windows installer
Date: Mon, 27 Nov 2017 17:56:58 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>> From: address@hidden (Phillip Lord)
>> Cc: address@hidden,  address@hidden,  address@hidden
>> Date: Sat, 25 Nov 2017 11:08:12 +0000
>> 
>> >> (defconst emacs-build-system
>> >>           (if (file-exists-p "~/.emacs-build-system-name")
>> >>               (with-temp-buffer
>> >>                 (insert-file-contents "~/.emacs-build-system-name")
>> >>                 (buffer-string))
>> >>              (system-name)))
>> >
>> > Where do you want to put this?  Are you going to patch the sources
>> > from which you produce the binaries?
>> 
>> master
>
> Then I think a much better way would be to access some environment
> variable instead of a file.  (Assuming there's no way for you to
> arrange for that system to return some string of your liking as the
> system name -- if that's possible, it would be preferable, because
> having in our code something that caters to building installable
> binaries on MS-Windows is not something I'd do happily.)


Hmm, yes. Changing the system name seems to work and doesn't seem to
break anything. This seems like an easier solution. Sorry for noise.

Phil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]