emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there'


From: Paul Eggert
Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961)
Date: Fri, 15 Dec 2017 09:13:19 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 12/15/2017 08:23 AM, Stefan Monnier wrote:
Is the problem caused by eassume (CONSP (Vframe_list))?
If so, maybe we should simply remove it.

That's a good idea. However, some calls to FOR_EACH_FRAME do assume that frame-list is non-nil, while others don't. So when we remove the eassume from FOR_EACH_FRAME, we should add it to callers that have the assumption (otherwise --enable-gcc-warnings would sometimes rightly complain). I installed the attached.

Attachment: 0001-FOR_EACH_FRAME-no-longer-assumes-frame-list.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]