Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961)

[Paul Eggert]

martin rudalics wrote:

>        eassume (CONSP (Vframe_list));
>
> now means that we can assume that `frame-list' is non-empty.  Isn't that
> assumption incorrect in the scenario of the bug we're discussing here?

Yes and no. The assumption is incorrect for this particular bug. But it is 
correct for the two instances of eassume (CONSP (Vframe_list)) that I resurrected.

>  > commit 8720f601e715e5f1d41f7cf863a525a1cc1bc12c
>  > removed these functions' assertions that frame-list is non-nil, so I
>  > thought it wise to resurrect them.
>
> I don't think that these assertions did any good and would remove them
> at least on master.

Sounds good to me. Assertions that aren't useful for finding bugs are more 
trouble than they're worth. I kept them only because I didn't know the context well.