[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types. |
Date: |
Thu, 21 Dec 2017 13:43:28 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> My suggestion would be to either at least document this breaking change
> (this patch), or forbid such records,
Hello? We've been through this discussion enough times, I believe.
I'm absolutely firmly completely totally opposed to such a check in
`make-record`.
Yes, a record of type `integer` or `hash-table` is not allowed.
No, we don't want to enforce this with a check in `make-record`.
> or change the return value in a non-breaking way (such as using
> '(record integer) and "#r(integer)").
Other parts of Emacs rely on the fact that (eq (type-of X) (type-of X)),
so if you want to return cons cells, you'll need to hash-cons them or
something. And the use of `integer` as record type is incorrect in any
case, so it would add complexity only to handle a situation that's
already incorrect.
You're making a mountain of a mole-hill, really.
Stefan
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., (continued)
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Stefan Monnier, 2017/12/14
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Stefan Monnier, 2017/12/12
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Noam Postavsky, 2017/12/12
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Stefan Monnier, 2017/12/12
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Stephen Leake, 2017/12/13
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Richard Stallman, 2017/12/13
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Stefan Monnier, 2017/12/14
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Richard Stallman, 2017/12/14
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Richard Stallman, 2017/12/14
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Philipp Stephani, 2017/12/21
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types.,
Stefan Monnier <=
- Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Richard Stallman, 2017/12/22
- [SUSPECTED SPAM] Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Stefan Monnier, 2017/12/22
- Re: [SUSPECTED SPAM] Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Richard Stallman, 2017/12/23
- make-record, Richard Stallman, 2017/12/23
- Re: make-record, Stefan Monnier, 2017/12/23
- Re: make-record, Richard Stallman, 2017/12/24
- Re: make-record, Stefan Monnier, 2017/12/25
- Re: make-record, Richard Stallman, 2017/12/26
Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types., Richard Stallman, 2017/12/12