emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix for bug#29935 copyright-update inserts year at random places


From: Stephen Leake
Subject: Re: fix for bug#29935 copyright-update inserts year at random places
Date: Thu, 04 Jan 2018 06:47:58 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt)

Stefan Monnier <address@hidden> writes:

>> I think there are still situations where pop-to-buffer-same-window can
>> change the window configuration (if it is invoked from a dedicated
>> window, for example), so save-window-excursion is still needed.
>
> In my config, pop-to-buffer-same-window will often/usually pop up a new
> frame (unless the buffer is already displayed somewhere, in which case
> it deiconifies and/or raises that frame), "so save-window-excursion is
> still needed^H^H^H^H^H^H^ineffective".
>
> This said, I actually do like that the buffer is shown in its
> own frame.  

So using pop-to-buffer-same-window, rather than pop-to-buffer, is ok for you.

> It would be nice to re-iconify the frame afterwards, tho.

Apparently completion (or maybe read-from-minibuffer) does re-iconify a
popped up frame (that happened once in my experiments). I looked thru
the C code for read-from-minibuffer, and it has comments that talk about
preserving the frame state, but I did not see where it minimizes the
frame on return. So I don't know how to do that from elisp in
copyright-update-year.

-- 
-- Stephe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]