emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: x-export-frames for non-Cairo builds


From: Stefan Monnier
Subject: Re: x-export-frames for non-Cairo builds
Date: Fri, 26 Jan 2018 09:45:32 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Please, not another x-FOO function that is very likely to have 4
> different implementations.  Instead, please define a single function
> whose name does NOT start with "x-",

Hear! Hear!

> and make it have a GTK-specific and a Cairo-specific implementation,
> which (the implementations) ideally should not be exported to Lisp.

And which code to use should be based on dispatching on the frame type
(so it can work even if we have several different kinds of frame types:
currently that's only true of "X11-vs-tty", more or less, but there's no
reason why we couldn't have GNUstep frames, W32 frames, and Gtk frames
all within the same Emacs session, at some point in the future).

>>       struct frame *f = decode_window_system_frame(frame);
                                                    ^^
Missing space.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]