emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warning "Obsolete name arg "password-store" to constructor auth-sour


From: Clément Pit-Claudel
Subject: Re: Warning "Obsolete name arg "password-store" to constructor auth-source-backend"
Date: Mon, 12 Feb 2018 11:12:57 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 2018-02-12 10:16, Alex Branham wrote:
> Hi all -
> 
> I'm seeing the following warning when byte compiling
> auth-password-store[1] on Emacs 26:
> 
>  auth-password-store.el:82:1:Warning: Obsolete name arg "password-store" to
>       constructor auth-source-backend
> 
> Does anyone have any idea what this could mean or how to fix it? I
> raised this in a github issue[2] and the package's authors seem as
> perplexed as I am.

Yes, see 2a61bd0096db23123734db439051c859e42b9606:

    ** EIEIO
    …
    *** The `newname' argument to constructors is optional&deprecated.
    If you need your objects to be named, do it by inheriting from 
`eieio-named'.

It comes from passing "password-store" to auth-source-backend.

Looks like Damien silenced that warning in auth-source-pass.el:

(defvar auth-source-pass-backend
  (auth-source-backend
   (format "Password store")
   :source "." ;; not used
   :type 'password-store
   :search-function #'auth-source-pass-search)
  "Auth-source backend for password-store.")

… which seems OK to do, since all callers of auth-source-backend in 
auth-source.el do it?  Maybe Stefan (who wrote that warning) can advise?

Clément.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]